Repository navigation
Conversation
… the strand The VENDOR line scanned only the newest 20 commits of the strand for the buffer's twin, while a firing vendors up to 100 commits onto the strand before the buffer picks any. With the strand 55 ahead it reported that something had vendored onto the buffer directly, a misdiagnosis that points the firing at the wrong repair. It now walks the whole strand, as `series-vendor.sh` does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SuHDnvaxmKU3CtRmWxsogi
…or-one.sh` A pass skips upstream commits that change nothing but the version stamp and folds them into the next one that moves. When a patch breaks on that next one, the patch rebased for it need not apply to the skipped commits before it, and the rerun the banner prescribes walks them again and breaks on the first. The banner now names them and the hand-made temporary commit that starts the walk at the broken commit instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SuHDnvaxmKU3CtRmWxsogi
…nter mismatches in C The glue gate syntax-checks every C file in `src/` with the system compiler. Before GCC 14 that compiler only warns about a call to a function the engine dropped or a callback of the wrong type. GCC 14 rejects both, and the first fails to link anyway. On the replay the gate let through `igraph_lcf_vector()` and the `RNG_BEGIN()` and `RNG_END()` macros, which upstream removed, and five pointer-type mismatches against changed callback and handler types. C files are now checked with those two warnings as errors. `main` passes the stricter gate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SuHDnvaxmKU3CtRmWxsogi
series-check.sh VENDOR misdiagnosis and broken patches after skipped candidates in vendor-one.shThis branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A scheduled series-loop firing on 2026-10-16 ran into three tooling problems in stage 1 and worked around them by hand. This PR fixes them, one commit each, because the firing could push to only one branch of this repository.
series-check.shsays the buffer led the strand when it is just behindThe VENDOR line looked for the buffer's twin among the newest 20 commits of
main-vendoronly (base_scan_depth). A firing vendors up to 100 commits onto the strand before the buffer picks any. With the strand 55 ahead ofmain-build(pushed by the previous firing, which never got to the pick), the check printed:That is the wrong diagnosis, and it sends a firing to the wrong repair.
series-vendor.shalready walks the whole strand for the same twin. The check now does the same and printsmain-vendor is 55 commit(s) ahead of main-build; stage 1 picks them.A patch rebased for a commit can break on the skipped candidates before it
vendor-one.shskips upstream commits that change nothing but the version stamp and folds them into the next commit that moves. When apatch/entry breaks on that next commit, the fold-in the banner prescribes puts the rebased patch in a temporary commit and reruns with--commits 1. The rerun walks the skipped candidates again, and the rebased patch does not apply to their older tree. So the run stops with exit 4 again, now naming the skipped commit.This happened twice in this firing with
patch/0004-chore-Fix-remaining-Stimulus-types.patch:igraph_get_shortest_paths()), after the skipped fb033592;EDGEWEIGHTSrenamed toEDGE_WEIGHTS), after the skipped 8f6c9024 and 2d634933.The hand workaround: the temporary commit also restamps
src/vendor/igraph_version.hfor the last skipped candidate and names it in its subject. That wayvendored_sha()counts it as vendored, and the walk starts at the broken commit. The squash then folds the stamp away. The resulting strand commit is the one an unbroken run would have written. The PATCH BROKEN banner now lists the skipped candidates and these steps when there are any. A real fix, such as letting the run start past the skipped candidates by itself, is left for discussion.The glue gate lets through what GCC 14 and the link reject
glue_compiles()syntax-checks the C glue with the system compiler. Before GCC 14 that compiler only warns about implicit function declarations and incompatible pointer types. On the replay the gate passed all 152 picks, while the buffer tip still callsigraph_lcf_vector()and theRNG_BEGIN()/RNG_END()macros, which upstream removed, and passes five callbacks or handlers of the wrong type (rcallback.c,rinterface_extra.c). These fail on GCC 14, and the removed functions fail to link anywhere. C files are now checked with-Werror=implicit-function-declaration -Werror=incompatible-pointer-types. Against the buffer tip the stricter gate flagsrcallback.c,rinterface.candrinterface_extra.c, and againstmainit passes.Checks
scripts/series-args-test.sh: 84 passed.scripts/vendor-one-test.sh: 77 passed.scripts/series-check.shagainst the fork, before the pick: the corrected VENDOR line shown above.glue_compiles(): passes onmain, and fails on themain-buildtip as described.Prepared with Claude Code, an LLM coding agent, during a scheduled series-loop firing.
🤖 Generated with Claude Code
https://claude.ai/code/session_01SuHDnvaxmKU3CtRmWxsogi